search

aodn / imos-toolbox

Graphical tool for QC'ing and NetCDF'ing oceanographic datasets
GNU General Public License v3.0
45 stars 30 forks source link

Asking user for depth/lat/long info in magneticDeclination and then not using it #790

Open sspagnol opened 1 year ago

sspagnol commented 1 year ago

In magneticDeclinationPP, if a sample doesn't have instrument_nominal_depth/geospatial_lat_min/geospatial_lon_min a dialog is created to ask the user for this information. But then line 93 is a continue statement https://github.com/aodn/imos-toolbox/blob/e19c8c604cd062a7212cdedafe11436209336ba5/Preprocessing/magneticDeclinationPP.m#L93

which continues the for loop and means that this info isn't used to do the magnetic declination calculation.

What was the reasoning behind this?