aodn / nrmn-application

A web application for collation, validation, and storage of all data obtained during surveys conducted by the NRMN
GNU General Public License v3.0
4 stars 3 forks source link

Deleting/changing superseded by not working #1202

Closed atcooper1 closed 1 year ago

atcooper1 commented 1 year ago

Unable to remove a superseded by species name and replace it with a valid name from the observable items list.

nspool commented 1 year ago

@atcooper1 which record are you editing and what are you trying to change the name to?

atcooper1 commented 1 year ago

E.g. Cromileptes altivelis - trying to remove the 'Superseded by' species (Chromileptes altivelis) so i can reverse the superseding (i.e. supersede Chromileptes with Cromileptes) but because i can't delete the exiting superseded buy species, i am unable to assign the correct name as it's already superseded.

atcooper1 commented 1 year ago

I can confirm I am able to:

However it seems i am also able to supersede a species with itself (i can select this from the drop down menu). This is problematic for circular referencing. In the example below, Pseudolabrus rubicundus is superseded with itself. image image

LizziOh commented 1 year ago

I have also tested this and find it to work well except for being able to supersede an obs item by its own name when the "superseded by" field is empty. Note that this is not consistent - it does not happen if trying to change an already populated "superseded by" field, as in the below example where i attempted to change it from Sargassum sonderi to itself (Sonderopelta coriacea). Note the blocking feed back is a bit misleading though as it the species does exist in the db and is valid. image

vfisaac commented 1 year ago

Fix implemented to prevent Superseded by field being populated with the Species name of the record you are editing. Available now in Verification for you to test