search

aodn / nrmn-application

A web application for collation, validation, and storage of all data obtained during surveys conducted by the NRMN
GNU General Public License v3.0
4 stars 3 forks source link

Package versions upgrading. #1327

Closed HavierD closed 10 months ago

HavierD commented 10 months ago

In Dependabot, some alerts are not able to solve (related to word-wrap, semver, and tough-cookie). It because that the react-scripts newest version 5.0.1 is using the earlier version of other sub-dependencies.

Node version specified in dockerfile.build & dockerfile are also upgraded.

Some packages have main version upgrade for solving alerts (including axios and jest/dom). May have unexpected issues in the future, but currently, I didn't come across errors.

@mui/style has deprecated and stop supporting react 17+ (we are using react 18). New ticket for it has created for next iteration.

utas-raymondng commented 10 months ago

Do no merge it after PR, some testing is going on in edge.

vietnguyengit commented 10 months ago

Do no merge it after PR, some testing is going on in edge.

yep no merge any time soon @utas-raymondng , looks like @HavierD still have a bunch of stuff to fix, I just make sure Docker stuff is fine for him to keep going on.

@HavierD see one of my commits, temporarily commented out complaining lines that deprecated , you need to turn it back on LOCALLY, so you can debug and fix.

HavierD commented 10 months ago

I have completed all work for this ticket. Please let me know when it can be merged, so that i can make the state of the pull request from DRAFT to READY.

vietnguyengit commented 10 months ago

next steps after all commits that to mark to READY then wait until official review on your PR by other devs. And move your backlog item into PR column

utas-raymondng commented 10 months ago

In Dependabot, some alerts are not able to solve (related to word-wrap, semver, and tough-cookie). It because that the react-scripts newest version 5.0.1 is using the earlier version of other sub-dependencies.

Node version specified in dockerfile.build & dockerfile are also upgraded.

Some packages have main version upgrade for solving alerts (including axios and jest/dom). May have unexpected issues in the future, but currently, I didn't come across errors.

@mui/style has deprecated and stop supporting react 17+ (we are using react 18). New ticket for it has created for next iteration.

Please include the new ticket url here thanks