Abbreviations used as column headers in BGC Combined table

aodn / public-schema

Shared schema specifications for data exchange (WFS, CSV, etc...)

GNU General Public License v3.0

1 stars 0 forks source link

Abbreviations used as column headers in BGC Combined table #52

Closed clairedavies closed 2 years ago

clairedavies commented 2 years ago

Please use the full names for the chemistry column headers and not abbreviations i.e. Ammonia not NH4 Same for "SiO4_umolL", "PO4_umolL", "NH4_umolL", "NO3_umolL", "N02_umolL"

clairedavies commented 2 years ago

ooppss Ammonium not ammonia

Nitrite is also missing and needs adding to the combined product

clairedavies commented 2 years ago

Also for the salinity headers you have used _PSU in the indices data and _psu in the combined bgc data. Most people are now dropping PSU as a unit, so it might be better to have no unit for salinity as I think that is the direction of the trend. A lot of journals are now insisting on it being removed.

clairedavies commented 2 years ago

synechococcus, prochlorococcus and picoeukaryote are abbreviated in the combined bgc data - is there a reason for this, I would prefer that they weren't, best to match the headers as they are supplied in the data files.

mhidas commented 2 years ago

is there a reason for this

Just following the product specifications... (for all products & column names) If we need to change them, that's fine, but it would be helpful to update the spec too so they remain consistent.

leonardolaiolo commented 2 years ago

Fix:

[x] change salinity_psu to salinity
[x] change NH4_umolL to Ammonium_umolL, NO3_umolL to Nitrate_umolL (same for flags)
[x] add nitrite in combined product and chemistry only -> kind of duplicate of this (#45)
[x] update synechococcus, prochlorococcus and picoeukaryote with full names
[x] update combined bgc product specification document consistently