Bit of a repetition in the commits due to a mistake on tagging the right issue - sorry. I tried to make it cleaner, but commits just got repeated. I hope it is not too confusing, please come around or ask me if something does not make sense.
Changes could have been done in different ways, I decided to change every single product instead of modifying the combined_bgc_map. I thought we could make Claire happy this way, as she asked in a recent email if the repetition of trip_code and Trip_Code could be avoided in the final products. Furthermore, because of the order of parameters, hard coding for each products could have been required anyway, as we now have different SampleTime_Local for each products and combined product (i.e., SELECT bm.* would not work) - and we do need to have SampleTime_Local in the combined_bgc_map otherwise Step 2 in AODN Portal breaks.
Bit of a repetition in the commits due to a mistake on tagging the right issue - sorry. I tried to make it cleaner, but commits just got repeated. I hope it is not too confusing, please come around or ask me if something does not make sense.
This should fix both these issues:
Changes could have been done in different ways, I decided to change every single product instead of modifying the
combined_bgc_map. I thought we could make Claire happy this way, as she asked in a recent email if the repetition oftrip_codeandTrip_Codecould be avoided in the final products. Furthermore, because of the order of parameters, hard coding for each products could have been required anyway, as we now have differentSampleTime_Localfor each products and combined product (i.e.,SELECT bm.*would not work) - and we do need to haveSampleTime_Localin thecombined_bgc_mapotherwise Step 2 in AODN Portal breaks.Geoserver needs this PR merged once this is on master (impacts filter) https://github.com/aodn/geoserver-config/pull/744