search

aodn / python-aodndata

Handlers, destination path functions and any other code specific to a given facility or pipeline
GNU General Public License v3.0
0 stars 0 forks source link

feat(standardization): move to png #201

Closed ocehugo closed 3 years ago

ocehugo commented 4 years ago

I was just checking the GLSA issue and saw that we are taking the easy road of keeping/including heavier dependencies just to support a legacy image format in a single test.

If we move the file format of the test to png, we can get rid of the pillow dependency.

ghost commented 4 years ago

Pillow is used to allow pyplot to output JPEGs for this pipeline: https://github.com/aodn/python-aodndata/blob/master/aodndata/soop/soop_xbt_dm.py#L120

To output JPGs such as (for one example): http://imos-data.s3-website-ap-southeast-2.amazonaws.com/?prefix=IMOS/SOOP/SOOP-XBT/DELAYED/Line_IX28_Dumont-d-Urville-Hobart/2013/

I'm all for fewer dependencies, but it might annoy the SOOP people if you drop Pillow prematurely!

ocehugo commented 4 years ago

damm - breaking urls then...

I almost said - just write a png file as a .jpg file cause no one will notice - until I remembered a certain popular OS...