search

aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network
GNU Lesser General Public License v3.0
10 stars 3 forks source link

aggregated_timeseries: fix dimension of LATITUDE and LONGITUDE #109

Closed mhidas closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #109 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   64.51%   64.54%   +0.03%     
==========================================
  Files           7        7              
  Lines         975      976       +1     
  Branches      154      154              
==========================================
+ Hits          629      630       +1     
  Misses        319      319              
  Partials       27       27
Impacted Files Coverage Δ
...tools/timeseries_products/aggregated_timeseries.py 87.3% <100%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d8c4a3...c8e587d. Read the comment docs.

mhidas commented 4 years ago

@ocehugo This is a simple fix for a bug that is currently blocking the publication of these products in prod (see https://github.com/aodn/issues/issues/658). Would you mind having a quick look and merging unless you see anything blatantly wrong?

ocehugo commented 4 years ago

I assumed I could ignore jenkins bug and trust travis instead.

mhidas commented 4 years ago

:+1: Thanks @ocehugo