Open ocehugo opened 4 years ago
Merging #120 (919b959) into master (ae8b06e) will increase coverage by
15.31%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #120 +/- ##
===========================================
+ Coverage 54.78% 70.09% +15.31%
===========================================
Files 9 12 +3
Lines 1150 1117 -33
Branches 167 146 -21
===========================================
+ Hits 630 783 +153
+ Misses 493 317 -176
+ Partials 27 17 -10
Impacted Files | Coverage Δ | |
---|---|---|
...tools/timeseries_products/aggregated_timeseries.py | 95.29% <ø> (+7.98%) |
:arrow_up: |
...odntools/timeseries_products/gridded_timeseries.py | 0.00% <ø> (ø) |
|
aodntools/timeseries_products/hourly_timeseries.py | 98.22% <ø> (+9.16%) |
:arrow_up: |
...eseries_products/velocity_aggregated_timeseries.py | 89.70% <ø> (+89.70%) |
:arrow_up: |
.../timeseries_products/velocity_hourly_timeseries.py | 0.00% <ø> (ø) |
|
aodntools/__init__.py | 100.00% <0.00%> (ø) |
|
aodntools/timeseries_products/common.py | 86.44% <0.00%> (ø) |
|
aodntools/ncwriter/__init__.py | 100.00% <0.00%> (ø) |
|
... and 2 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Note that this changes many of the command-line arguments
This brings the interface more in line with standard command-line tools (on Linux).
@alexgleith Why did you close this? I still think it's relevant, though not high priority for us as we run this code with a Python process, not from a shell. However, as this is an open-source repo (I know at least one group at UNSW using it), the command-line functionality is there and this changes it in a non-backwards-compatible way, I'm saving this until we're ready to release a v2 (see https://github.com/aodn/python-aodntools/milestones)
I closed it because it hadn't been touched for over a year. Sorry :-)
Just small annoying bits - missing shebangs and non-standard cmd line arguments lines. @mhidas, worth checking if this is safe since I didn't check how you handle the calls to these tools .