search

aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Fix minor bugs in timeseries product codes #127

Closed mhidas closed 4 years ago

mhidas commented 4 years ago

Just picking off some low-hanging fruit.

Addresses the first two bugs listed in https://github.com/aodn/PO-Backlog/issues/1027 I was hoping to tackle the third one as well, but it might be easier to do it in a separate PR.

codecov[bot] commented 4 years ago

Codecov Report

Merging #127 into master will increase coverage by 13.25%. The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #127       +/-   ##
===========================================
+ Coverage   54.78%   68.03%   +13.25%     
===========================================
  Files           9       10        +1     
  Lines        1150     1167       +17     
  Branches      167      171        +4     
===========================================
+ Hits          630      794      +164     
+ Misses        493      338      -155     
- Partials       27       35        +8
Impacted Files Coverage Δ
.../timeseries_products/velocity_hourly_timeseries.py 0.00% <0.00%> (ø)
...eseries_products/velocity_aggregated_timeseries.py 86.04% <84.21%> (+86.04%) :arrow_up:
...tools/timeseries_products/aggregated_timeseries.py 87.86% <100.00%> (+0.55%) :arrow_up:
aodntools/timeseries_products/common.py 100.00% <100.00%> (ø)
aodntools/timeseries_products/hourly_timeseries.py 91.28% <100.00%> (+2.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae8b06e...5978dc8. Read the comment docs.

mhidas commented 4 years ago

@ocehugo Ready for review. There's quite a bit going on. It might make more sense looking at it one commit at a time (hopefully).

Note: I know the unittests are not quite complete, and there's plenty of refactoring that could be done, but these will be addressed later. For now I'm just trying to focus on fixing those bugs.

mhidas commented 4 years ago

Thanks @ocehugo . I made a few simple changes based on your suggestions. As I said, I'd like to do more extensive refactoring in a separate PR.

This should be good to merge now. Cheers