Closed mhidas closed 4 years ago
@ocehugo Sorry I forgot to add a test file to the repo. I just added it and force pushed. Should pass the checks now.
Merging #128 into master will increase coverage by
1.92%
. The diff coverage is84.61%
.
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 68.03% 69.96% +1.92%
==========================================
Files 10 10
Lines 1167 1112 -55
Branches 171 146 -25
==========================================
- Hits 794 778 -16
+ Misses 338 317 -21
+ Partials 35 17 -18
Impacted Files | Coverage Δ | |
---|---|---|
.../timeseries_products/velocity_hourly_timeseries.py | 0.00% <0.00%> (ø) |
|
setup.py | 0.00% <ø> (ø) |
|
aodntools/timeseries_products/common.py | 86.44% <85.96%> (-13.56%) |
:arrow_down: |
...tools/timeseries_products/aggregated_timeseries.py | 95.29% <100.00%> (+7.43%) |
:arrow_up: |
aodntools/timeseries_products/hourly_timeseries.py | 98.22% <100.00%> (+6.93%) |
:arrow_up: |
...eseries_products/velocity_aggregated_timeseries.py | 89.70% <100.00%> (+3.65%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b68c421...023ff7b. Read the comment docs.
Two things made harder to review this bit:
Somehow github is not playing well with the force push. I can't see all changes by navigating in a per commit basis, I keep looking at the outdate commits and the only way to see the updated ones is to see everything in one page (File Changes).
The commit msgs could be more helpful, since it's more going on than it's descrived :)
@mhidas , will leave to you if you want to follow up on my comments or just merge
Thanks @ocehugo I appreciate your comments, but I don't want to spend any more time on this PR, so I'll merge it.
Fixes #126