aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network

GNU Lesser General Public License v3.0

10 stars 3 forks source link

(Fix) https://github.com/aodn/python-aodntools/issues/46 #143

Closed lbesnard closed 3 years ago

lbesnard commented 3 years ago

@mhidas, is that all that needs to be done?

codecov[bot] commented 3 years ago

Codecov Report

Merging #143 (b2fe349) into master (fea8fd9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   70.33%   70.33%           
=======================================
  Files          12       12           
  Lines        1126     1126           
  Branches      146      146           
=======================================
  Hits          792      792           
  Misses        317      317           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fea8fd9...b2fe349. Read the comment docs.

mhidas commented 3 years ago

@mhidas, is that all that needs to be done?

That fixes it for data types specified as "float16". However, as I suggested, a complete fix would include reviewing the full list in that enum and removing all type specifications that are not supported in netCDF. I think the other "intN" and "floatN" type should be fine, but not sure about some of the single-character codes.

Probably the easiest way to do this is to try creating a NetCDF variable with each of those types and see if you get the error

lbesnard commented 3 years ago

the full list in that enum and removing all type specifications that

I did that and everything else seemed to be valid

mhidas commented 3 years ago

:+1: Great!