search

aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Fix centering of hourly interval #153

Closed mhidas closed 2 years ago

mhidas commented 2 years ago

The averaging intervals for the hourly product were not actually centered on the hour (as specified) due to an issue with specifying units in pandas.Timedelta (see https://github.com/aodn/python-aodntools/pull/99#discussion_r391440014)

(Still need to check whether the same fix need to be applied to the velocity_hourly product - but if so this will be done in a separate PR)

codecov[bot] commented 2 years ago

Codecov Report

Merging #153 (96f8040) into master (ab01d2a) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files          12       12           
  Lines        1133     1133           
  Branches      153      153           
=======================================
  Hits          799      799           
  Misses        317      317           
  Partials       17       17
Impacted Files Coverage Δ
aodntools/timeseries_products/hourly_timeseries.py 98.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab01d2a...96f8040. Read the comment docs.