aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Fix a failing test, which was failing due to modifying a list in plac… #169

Closed alexgleith closed 2 years ago

alexgleith commented 2 years ago

Added a little test case to test single files. Discovered the issue is in the main_aggregator function modifying a list in place. Could be unique to my Python version, but wanted to send it in anyway.

Most of these changes are formatting... sorry about that.

codecov[bot] commented 2 years ago

Codecov Report

Merging #169 (49d2354) into master (c695897) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   84.88%   84.90%   +0.02%     
==========================================
  Files          12       12              
  Lines        1131     1133       +2     
  Branches      156      156              
==========================================
+ Hits          960      962       +2     
  Misses        152      152              
  Partials       19       19              
Impacted Files Coverage Δ
...tools/timeseries_products/aggregated_timeseries.py 95.18% <100.00%> (+0.05%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

alexgleith commented 2 years ago

I've split this into two commits @mhidas

mhidas commented 2 years ago

What about something as simple as this? #172