aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Fix issue with moving temporary files #178

Closed mhidas closed 1 year ago

mhidas commented 1 year ago

Thanks @mphemming for identifying and fixing this issue. (commits cherry-picked from #176)

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.54% // Head: 85.58% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (a2ca613) compared to base (2b1f81e). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #178 +/- ## ========================================== + Coverage 85.54% 85.58% +0.03% ========================================== Files 10 10 Lines 1128 1131 +3 Branches 156 153 -3 ========================================== + Hits 965 968 +3 Misses 144 144 Partials 19 19 ``` | [Impacted Files](https://codecov.io/gh/aodn/python-aodntools/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aodn) | Coverage Δ | | |---|---|---| | [...tools/timeseries\_products/aggregated\_timeseries.py](https://codecov.io/gh/aodn/python-aodntools/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aodn#diff-YW9kbnRvb2xzL3RpbWVzZXJpZXNfcHJvZHVjdHMvYWdncmVnYXRlZF90aW1lc2VyaWVzLnB5) | `95.20% <100.00%> (+0.02%)` | :arrow_up: | | [...eseries\_products/velocity\_aggregated\_timeseries.py](https://codecov.io/gh/aodn/python-aodntools/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aodn#diff-YW9kbnRvb2xzL3RpbWVzZXJpZXNfcHJvZHVjdHMvdmVsb2NpdHlfYWdncmVnYXRlZF90aW1lc2VyaWVzLnB5) | `91.91% <100.00%> (+0.05%)` | :arrow_up: | | [.../timeseries\_products/velocity\_hourly\_timeseries.py](https://codecov.io/gh/aodn/python-aodntools/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aodn#diff-YW9kbnRvb2xzL3RpbWVzZXJpZXNfcHJvZHVjdHMvdmVsb2NpdHlfaG91cmx5X3RpbWVzZXJpZXMucHk=) | `95.23% <100.00%> (+0.02%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aodn). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aodn)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mphemming commented 1 year ago

@mhidas happy for you to proceed with this one. I'll start a new branch for future pull requests ..

mhidas commented 1 year ago

@leonardolaiolo This is a quick & easy one to review. The changes are actually from @mphemming but I can't merge it without an approving review, and GitHub doesn't let me request a review from him... (Let me know if you'd like more context)

leonardolaiolo commented 1 year ago

Done @mhidas - I'll leave it to you to merge then.