search

aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Move schema to a JSON file #32

Closed mhidas closed 5 years ago

mhidas commented 5 years ago

Fixes #20

codecov[bot] commented 5 years ago

Codecov Report

Merging #32 into master will increase coverage by 0.09%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #32      +/-   ##
=========================================
+ Coverage   91.81%   91.9%   +0.09%     
=========================================
  Files           2       2              
  Lines         171     173       +2     
  Branches       29      29              
=========================================
+ Hits          157     159       +2     
  Misses         11      11              
  Partials        3       3
Impacted Files Coverage Δ
ncwriter/template.py 90.27% <100%> (ø) :arrow_up:
ncwriter/schema.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbeeb40...7a9ee29. Read the comment docs.

mhidas commented 5 years ago

@lwgordonimos Following your suggestion (https://github.com/aodn/aodn-netcdf-tools/pull/3#discussion_r219022116)

mhidas commented 5 years ago

One thing I'm not quite sure about is if we eventually want to use the schema from other code, it should probably be in a separate schema directory outside ncwriter, but it would still need to be included in the package. Can we still do that in setup.py with the package_data parameter? (e.g. like here)

mhidas commented 5 years ago

See last commit for adding the template JSON file as package data.

Looks like we have the same Travis issue as in aodncore...