search

aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Allow special variable attributes and simplify create_variables method #38

Closed mhidas closed 5 years ago

mhidas commented 5 years ago

The code was already handling these special "structural" attributes, which get passed on to the netCDF4.Dataset.createVariable method, but they were not allowed in the template schema. This PR adds those attributes in the schema, and also simplifies the code a bit.

codecov[bot] commented 5 years ago

Codecov Report

Merging #38 into master will increase coverage by 3.8%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #38     +/-   ##
=======================================
+ Coverage   96.19%   100%   +3.8%     
=======================================
  Files           2      2             
  Lines         184    169     -15     
  Branches       38     29      -9     
=======================================
- Hits          177    169      -8     
+ Misses          5      0      -5     
+ Partials        2      0      -2
Impacted Files Coverage Δ
ncwriter/template.py 100% <100%> (+4.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e3f55c...737ed67. Read the comment docs.