aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network
GNU Lesser General Public License v3.0
10 stars 3 forks source link

Jenkinsfile For aodn-netcdf-tools #42

Closed pmbohm closed 5 years ago

pmbohm commented 5 years ago

for aodn/backlog#1118

codecov[bot] commented 5 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #42   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         222    222           
  Branches       36     36           
=====================================
  Hits          222    222

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5dce55...d3fe1a4. Read the comment docs.

akashisama commented 5 years ago

@lwgordonimos bumpversion seems to bet setting it to the same version (0.2.1.dev0) for every build? See my 3 builds at http://jenkins-alexs-fresh-jenkins.dev.aodn.org.au/job/aodn-netcdf-tools_build/job/Jenkinsfile/

akashisama commented 5 years ago

Ah ok just noticed the "when { branch 'master' }" line, that's presumably where I was going wrong

akashisama commented 5 years ago

@lwgordonimos I created a branch that set itself as the master and had the same problem. I think there needs to be a git push after "bumpversion --tag --commit release" so the version change is kept track of?

http://jenkins-alexs-fresh-jenkins.dev.aodn.org.au/job/aodn-netcdf-tools_build/job/alexs-jenkinsfile/

ghost commented 5 years ago

Yeah, I didn't want to interact with Github during development too much.

In prod it will need something like: git push origin --tags

Mentions it here: https://github.com/peritus/bumpversion

tag = (True | False)

    default: False (Don't create a tag)

    Whether to create a tag, that is the new version, prefixed with the character "v".
If you are using git, don't forget to git-push with the --tags flag.
akashisama commented 5 years ago

I'm a bit worried about merging this since the versioning changes will break the current jenkins build/release process...

ghost commented 5 years ago

Yes, I was going to mention that this morning. Start with the non-Python projects first, and we might need to pull the version related stuff out and deal with it when we look at releases.