aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network

GNU Lesser General Public License v3.0

10 stars 3 forks source link

aggregated time series - pure numpy version #89

Closed diodon closed 4 years ago

diodon commented 4 years ago

This code produces exactly the same aggregated-timeseries product using aprox. half of the memory resources, and it is a little bit faster. Also, the data variables are compressed, generating a compact output file.

codecov[bot] commented 4 years ago

Codecov Report

Merging #89 into master will decrease coverage by 20.65%. The diff coverage is 0%.

@@             Coverage Diff             @@
##           master      #89       +/-   ##
===========================================
- Coverage   89.34%   68.68%   -20.66%     
===========================================
  Files           5        6        +1     
  Lines         685      891      +206     
  Branches      120      150       +30     
===========================================
  Hits          612      612               
- Misses         41      247      +206     
  Partials       32       32

Impacted Files	Coverage Δ
...ls/timeseries_products/aggregated_timeseries_NP.py	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c08b045...e17aa6a. Read the comment docs.

mhidas commented 4 years ago

@diodon I assume #97 makes this PR redundant, so we can close it?

diodon commented 4 years ago

Yes.please close it.

On Fri, 14 Feb 2020, 11:19 Marty Hidas, notifications@github.com wrote:

@diodon https://github.com/diodon I assume #97 https://github.com/aodn/python-aodntools/pull/97 makes this PR redundant, so we can close it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aodn/python-aodntools/pull/89?email_source=notifications&email_token=AATPADY4FGSYCTKO65KUOO3RCXPRNA5CNFSM4J5QV3AKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELXDLAY#issuecomment-586036611, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATPAD4EB5ZEOVVOLKYU633RCXPRNANCNFSM4J5QV3AA .