search

aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network
GNU Lesser General Public License v3.0
10 stars 3 forks source link

aggregated_timeseries: fix file sorting issue #98

Closed mhidas closed 4 years ago

mhidas commented 4 years ago

Sorry, this was a bug caused by my review suggestion! The file list needs to be sorted before working out the list of variable lengths, so that the order of the two lists remains consistent!

I've also updated the unittest to test for this bug (it was only passing because the test files were already in chronological order!)

codecov[bot] commented 4 years ago

Codecov Report

Merging #98 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   80.51%   80.51%           
=======================================
  Files           6        6           
  Lines         780      780           
  Branches      125      125           
=======================================
  Hits          628      628           
  Misses        125      125           
  Partials       27       27
Impacted Files Coverage Δ
...tools/timeseries_products/aggregated_timeseries.py 87.17% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 733e909...38ddcd7. Read the comment docs.