aodn / python-aodntools

Repository for templates and code relating to generating standard NetCDF files for the Australia Ocean Data Network

GNU Lesser General Public License v3.0

10 stars 3 forks source link

Velocity HOURLY #99

Closed diodon closed 4 years ago

diodon commented 4 years ago

This code aggregates the flattened velocity variables binned into one hour time intervals. It checks for the presence of seconds_to_middle_of_measurement and lags forward the timestamp. Here is a sample file aggregating 20 deployments from NRSDAR

codecov[bot] commented 4 years ago

Codecov Report

Merging #99 into master will not change coverage by %. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   54.78%   54.78%           
=======================================
  Files           9        9           
  Lines        1150     1150           
  Branches      167      167           
=======================================
  Hits          630      630           
  Misses        493      493           
  Partials       27       27

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fef2508...fef2508. Read the comment docs.

diodon commented 4 years ago

The code does not shift the TIME according to seconds_to_middle. However, the portions of the code that do this are commented in case we want to go back and use this approach

mhidas commented 4 years ago

@ocehugo If you have a bit of time today, please take a quick look at this & merge unless you find anything really broken. You only really need to look at the last 9 commits (starting with https://github.com/aodn/python-aodntools/pull/99/commits/bd151bce480eec61bb0b76f16b5f4cd103b7fd4a), as the rest were done by @diodon and reviewed by me.

mhidas commented 4 years ago

Note the Travis tests are failing due to https://github.com/aodn/issues/issues/692, but a fix is almost ready.

ocehugo commented 4 years ago

@mhidas - I'm leaving to you to merge of just a single thing - there a change on the time resampling (forward shifting instead of backward) that I assumed was further checked?

mhidas commented 4 years ago

Thanks @ocehugo. I will update that commit, fix the merge conflicts (due to version numbers changing after the other PR was merged) and merge.