search

aofei / air

An ideally refined web framework for Go.
https://pkg.go.dev/github.com/aofei/air
MIT License
441 stars 37 forks source link

Need Configuration Variable for Email in autocert.Manager{} #10

Closed SaulDoesCode closed 5 years ago

SaulDoesCode commented 5 years ago

https://github.com/aofei/air/blob/e62e9ff25eefecad7a97b37642bba8f5846bf035/server.go#L64

acm := autocert.Manager{
    Prompt: autocert.AcceptTOS,
    Cache:  autocert.DirCache(ACMECertRoot),
}

if MaintainerEmail != "" {
  acm.Email = MaintainerEmail
}

In the TOML maybe allow users to add maintainer_email

aofei commented 5 years ago

Sounds great, can you submit a PR? Thanks~

aofei commented 5 years ago

Thanks for the #11~