search

aol / micro-server

Microserver is a Java 8 native, zero configuration, standards based, battle hardened library to run Java Rest Microservices via a standard Java main class. Supporting pure Microservice or Micro-monolith styles.
http://micro-server.io/
Apache License 2.0
940 stars 212 forks source link

Remove compile dependancy on lombok #359

Open morrowgi opened 7 years ago

morrowgi commented 7 years ago

The following is in the build.gradle file of micro-server and it should be removed:

compile(group: 'org.projectlombok', name: 'lombok', version:'1.16.2') { This dependency was originally in the Maven provided scope, but the project was not of type war.   This behavior is not yet supported by Gradle, so this dependency has been converted to a compile dependency.   Please review and delete this closure when resolved.   }

This should use provided scope

quike commented 7 years ago

With https://github.com/aol/micro-server/pull/381 We could remove this bug. It introduces new gradle wrapper version 2.14.1 with the use of compileOnly dependency strategy to avoid transitive dependencies and use them only on compiling time (lombok).

More info here: https://projectlombok.org/setup/gradle https://blog.gradle.org/introducing-compile-only-dependencies