aolabNeuro / brain-python-interface

Other
4 stars 2 forks source link

when ecube is not initialized the error causes everything to hang rather than forwarding to the UI #43

Closed leoscholl closed 3 years ago

leoscholl commented 3 years ago

this is presumably because pre_init() is left out of the main try/finally statement in the main loop

leoscholl commented 3 years ago

related to #32

leoscholl commented 3 years ago

fixed in 9846f1cc4f2fb51153b044d1de3837be76c54714 by having a class variable that keeps track of the ecube status so we can move the error into the beginning of run()

also fixed #32 and the reward system feature using this approach.

maybe it would make sense to wrap the pre_init, __init__, and init functions in their own try/catch for these reasons, i'm not exactly sure how that would work.