search

aoles / EBImage

:art: Image processing toolbox for R
71 stars 28 forks source link

Added the ability for different boundary values for different frames #11

Closed ghaarsma closed 7 years ago

ghaarsma commented 7 years ago

Small modification in the linear boundary filter to have correct padding.

Also added the ability to have different linear boundary values for different frames. This will allow you to match color in a RGB images for example.

Updated the documentation for filter2 to reflect this and added examples.

aoles commented 7 years ago

Hi Gabe, thank you for your patience and for addressing my comments. I think we're almost good to go, please have a look at the remaining issue with the padding size.

Cheers, Andrzej

ghaarsma commented 7 years ago

Andrzej,

Updated pull request to address your two outstanding items.

  1. Changed it back to quoted expressions in the do.call. I was hoping that my implementation was slightly faster, but I checked with microbenchmark and the difference is insignificant.

  2. Changed back to 'single' style padding for the linear boundary as you had it originally. Not quite sure what happened but I thought that your implementation was incorrect after I ran some tests. After trying again, I could not reproduce that and it turns out that your implementation should indeed just work fine.

Thanks for your patience, Gabe

aoles commented 7 years ago

Awesome, many thanks Gabe for contributing to the package. Your work is very much appreciated.

Cheers, Andrzej