search

aolsenjazz / libsamplerate-js

Resample audio in node or browser using a web assembly port of libsamplerate.
Other
32 stars 10 forks source link

Upgrade @typescript-eslint/eslint-plugin to version 5.0.0 #12

Closed depfu[bot] closed 3 years ago

depfu[bot] commented 3 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ @​typescript-eslint/eslint-plugin (^4.31.0 → ^5.0.0) · Repo · Changelog

Release Notes

5.0.0

5.0.0 (2021-10-11)

Breaking Release Notes

All Packages

  • Support for ESLint v8 (see individual packages for relevant breaking changes).
  • Drop support for Node v10 - required node version is now ^12.22.0 || ^14.17.0 || >=16.0.0.
    • Node v10 was EOL'd in April 2021, and ESLint v8 dropped support for it too.
  • Drop Support for ESLint v5
    • ESLint v5 is now 3 years old - why are you still using it? Upgrade to at least ESLint v6.

ESLint-Plugin

  • Changes to the recommended rule set - see #3746
  • [ban-types] remove object from the default ban list
    • This has been a point of contention for a while - I originally added it because TS currently makes it impossible to narrow the type nicely. However there ultimately isn't a good alternative to this type for many usecases. As such we're removing the default ban. If you want to continue banning it, you can configure the rule to do so.
  • [comma-dangle] align schema with ESLint v8
    • Should be pretty transparent unless you were using an invalid config.
  • [explicit-member-accessibility] now checks abstract members
  • [member-ordering] add support for getters and setters
    • This will likely cause your codebase's sort orders to change if you're using the default config.
  • [no-unused-vars-experimental] rule has been deleted
    • You should instead use @typescript-eslint/no-unused-vars instead! It has had full and awesome support for TypeScript since v4.9.0 - and it doesn't require type information!

Experimental-Utils:

  • Remove SourceCode#getComments API from ESLint types.
    • This API was deprecated in ESLint v4, and its usage will error in ESLint v8.
  • Support ESLint v8:
    • CLIEngine is now conditionally undefined. It was deprecated in v7 and removed in v8. If you're still using it, you should upgrade to the ESLint API.
    • Remove meta.docs.category. ESLint has removed this from their core rules as it wasn't ever very useful and was always poorly done. We have followed suit and removed it from our types and our rules.

TypeScript-ESTree / AST-Spec

  • Change .source of ExportNamedDeclaration, ExportAllDeclaration and ImportDeclaration to StringLiteral and add parse-time errors.
    • This ensures we're aligned with ESTree and producing the correct AST.
  • Remove TSParenthesizedType node.
    • This node was added when this project was first created because the TS-AST includes this node. However it ultimately conveys no actual AST meaning (just like parentheses in non-type code). Babel removed this node earlier this year.
    • We expect rules will continue to "just work". In a lot of cases rules will work better as they no longer need manual checks to "look past" the useless node.
  • Remove legacy option useJSXTextNode.
    • This option was added for compatibility between different ASTs a very long time ago - but all ASTs have converged on using JSXText - so you should be using that too.
  • Align class features AST with ESTree. This aligns with ESLint v8.
    • ClassProperty is now called PropertyDefinition
    • TSAbstractClassProperty is now called TSAbstractPropertyDefinition
  • TSAbstractPropertyDefinition.value is now always null.
    • It never made sense that this was allowed, and TS4.4 has now made this invalid.
  • Add full support for PrivateIdentifier (#private class members)
    • Previously we did not officially support them and emitted an "unstable" AST.
    • This will allow the community to build lint rules specifically targeting #private members.
  • Rename LineAndColumnData to Position (aligns naming with the ESTree spec docs)

Scope-Manager

  • Class properties with values now create a 'class-field-initializer' type scope around their value.
    • This aligns with eslint-scope v6.

Raw Changelog

Bug Fixes

  • eslint-plugin: [explicit-member-accessibility] report TSAbstractPropertyDefinition and TSAbstractMethodDefinition properly (#3901) (82016f9)
  • eslint-plugin: update new rules from master (#3840) (d88a6b4)
  • update new rules from master (b34fb7e)
  • eslint-plugin: crash in no-dupe-class-members (v5) (#3813) (4b09644)
  • experimental-utils: fix isSetter's return type (#3975) (d256856)
  • typescript-estree: change source of ExportNamedDeclaration to Literal from Expression (#3763) (dc5a0f5)

Features

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 44 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot] commented 3 years ago

Closed in favor of #14.