aome510 / spotify-player

A Spotify player in the terminal with full feature parity
MIT License
3.39k stars 149 forks source link

Blank space drawn on top left blocking content if `playback_window_position` is `Bottom` #326

Closed ed9w2in6 closed 8 months ago

ed9w2in6 commented 8 months ago

Symptom Weird album art artefact drawn on terminal when playback_window_position is set to Bottom as shown in this screenshot: image

Blank space drawn on top left that matches the dimensions of the album art. I guess some logic that allocates space fell through some branch checks. You won't notice this if playback_window_position is set to Top.

Expected behavior There should NOT be blank space on the top left.

To Reproduce

  1. clean install of spotify_player with the image feature
  2. start spotify_player to generate default app.toml
  3. change playback_window_position to Bottom
  4. start spotify_player

Log and backtrace No obvious trace from logs, will provide if needed.

Environment

Additional context Issue appeared since version 0.16.2.

Issue rating

aome510 commented 8 months ago

@ed9w2in6 should be fixed by #328. Can you check out and run the branch locally to see if the fix works?

apprehensions commented 8 months ago

20240103_200736 Solves my issue!

ed9w2in6 commented 8 months ago

@aome510 wow I did not expect you to fix this that quickly, thanks!
I can confirm that it solves the issue for me as well and again thank you for your time on fixing this.