Unable show album cover in tmux.

aome510 / spotify-player

A Spotify player in the terminal with full feature parity

MIT License

3.14k stars 137 forks source link

Unable show album cover in tmux. #404

Closed xbunax closed 3 months ago

xbunax commented 3 months ago

Unable show album cover in tmux. Left is tmux, right is iterm2

I don't know wether this is the problem of spotify_player or the tmux. Like the issue

This is my system info

                'c.          xbunax@MacBook-Air-3.local
             ,xNMM.          --------------------------
           .OMMMMo           OS: macOS 14.4.1 23E224 arm64
           OMMM0,            Host: Mac14,2
 .;loddo:' loolloddol;.      Kernel: 23.4.0
cKMMMMMMMMMMNWMMMMMMMMMM0:    Uptime: 12 hours, 46 mins
.KMMMMMMMMMMMMMMMMMMMMMMMWd.    Packages: 1 (port), 238 (brew)
XMMMMMMMMMMMMMMMMMMMMMMMX.      Shell: zsh 5.9
;MMMMMMMMMMMMMMMMMMMMMMMM:       Resolution: 2560x1440
:MMMMMMMMMMMMMMMMMMMMMMMM:       DE: Aqua
.MMMMMMMMMMMMMMMMMMMMMMMMX.      WM: Amethyst
kMMMMMMMMMMMMMMMMMMMMMMMMWd.    Terminal: iTerm2
.XMMMMMMMMMMMMMMMMMMMMMMMMMMk   Terminal Font: MesloLGS-NF-Regular 14
.XMMMMMMMMMMMMMMMMMMMMMMMMK.   CPU: Apple M2
kMMMMMMMMMMMMMMMMMMMMMMd     GPU: Apple M2
 ;KMMMMMMMWXXWMMMMMMMk.      Memory: 2950MiB / 16384MiB
   .cooc,.    .,coo:.

the version of spotify_player
```
spotify_player 0.17.1
```

aome510 commented 3 months ago

I believe it's tmux issue. I remember some terminal emulators, e.g tmux or allacrity, don't support rendering full-resolution images. That said, it's weird to not see anything rendered. What does the image area look like when running tmux inside other terminals than iterm2?

xbunax commented 3 months ago

I believe it's tmux issue. I remember some terminal emulators, e.g tmux or allacrity, don't support rendering full-resolution images. That said, it's weird to not see anything rendered. What does the image area look like when running tmux inside other terminals than iterm2?

I use kitty to run tmux, but the result is the same

Keep-Simple commented 3 months ago

mdkcore0 commented 3 months ago

I believe it's tmux issue. I remember some terminal emulators, e.g tmux or allacrity, don't support rendering full-resolution images. That said, it's weird to not see anything rendered. What does the image area look like when running tmux inside other terminals than iterm2?

as aome510 said, it depends on your terminal emulator and tmux; for example, alacritty do not support sixel (there is a build that do enable that), and tmux needs to be compiled with the --enable-sixel flag (was added on version 3.4, maybe this is the issue you are facing here)

finally, spotify-player must be built with image or sixel enabled

this is what it looks likes with the image feature enabled, running on alacritty/tmux (catppuccin-mocha btw? :p):

xbunax commented 3 months ago

--enable-sixel

Interesting, I build tmux and spotify_player with image feature, but the image still disappear wether it's in iterm2 or kitty

aome510 commented 3 months ago

I think tmux doesn't support render image in full resolution, image is still rendered when running in terminal that doesn't support full resolution based on @mdkcore0's comment. My guess is that the terminal renders full-resolution image but tmux doesn't know how to handle the image, so it just renders a black screen.

I'll close this issue for now as I'm not sure if there is anything we can do from spotify_player side