aome510 / spotify-player

A Spotify player in the terminal with full feature parity
MIT License
3.14k stars 137 forks source link

Pressing ESC while in search mode will bypass input to search so that keycommands can be pressed. #430

Open ghost opened 2 months ago

ghost commented 2 months ago

I have FocusPreviousWindow and FocusNextWindow remapped to h and l respectively, and I exclusively use j and k for movement between selections. In the search bar, Ctrl-n and Ctrl-p still work for selecting, but j and k are captured by the search bar. Likewise in the search page, tab and shift-tab still work, but h and l are captured.

The ideal solution would be to make it so when esc is pressed, (vim style) text no longer is captured by search, and "i", or "gi" can be pressed to return to insert mode. Also, if enter is pressed, focus should automatically go to the results window.

ghost commented 2 months ago

In the search bar, escape closes the bar entirely, cancelling the search. I guess it makes more sense for esc to be cancel, and use enter to focus on the results window.