Add foreign language support for lyrics - Githubissues

aome510 / spotify-player

A Spotify player in the terminal with full feature parity

MIT License

3.37k stars 146 forks source link

Add foreign language support for lyrics #509

Closed smlocke closed 1 month ago

smlocke commented 1 month ago

For lyric-finder, how do we feel about adding support for non-Western characters when displaying lyrics?

Current state: Hangul characters don't render on lyrics page. Environment: Windows 10 laptop running spotify_player.exe via command line and via PowerShell

aome510 commented 1 month ago

ayo, no way I'm listening to the same album when replying to this issue 😮 . Anyway, Hangul works well for me:

How the characters are rendered does not depend on the application itself but your terminal's font

smlocke commented 1 month ago

Bro's got taste! Thank you for responding, I'll have to go poke at my font.

I can file a separate issue for this, but I wanted you to consider a related matter: stan Dreamcatcher, stream Justice