aome510 / spotify-player

A Spotify player in the terminal with full feature parity
MIT License
3.63k stars 166 forks source link

Improved Lyric_finder to retrieve correct lyrics instead of its translation #564

Closed genricoloni closed 2 months ago

genricoloni commented 2 months ago

Hi, I noticed that for some lyrics, one of its translation is shown instead of the actual lyric, and this because for some obscure reason Genius responses by putting these translations at the top of the results. You can reproduce this behavior by playing the song "Kingslayer" by "Bring Me The Horizon". Fortunately, all the results results (at least the bunch of those I checked manually to implement this fix) have "Genius < language > <_translation_ written in that language>" as artist_name so a find() is used to exclude the results with keyword Genius in that field. The rest of the code hasn't changed, so the first result is chosen.