aonemd / kuroi.vim

A very dark colorscheme for Vim. JOIN THE DARK SIDE!
MIT License
200 stars 16 forks source link

Clarifying the visual of MatchParen. #3

Closed keysym closed 5 years ago

keysym commented 5 years ago

This clarifies the color patterns of the matched parentheses. Consider these examples, where the cursor is positioned over the leftmost parentheses:

image The current state does not make much sense as this highlights the corresponding parenthesis more than the cursor.

image I personally think this way it is clearer to identify where the cursor is located.

Thanks for listening!

aonemd commented 5 years ago

Hello! Thanks for opening the pull request!

In your first screenshot, I don't understand why the cursor is hidden. Maybe you need to set the cursor color in your terminal config?

Anyway, Here's how it currently looks in my terminal:

screenshot_2019-06-16_09:04:27

Don't you think that the matching parenthesis purple background color is enough to highlight it?

Also, I understand that this is such a small change, however; from a perfectionist point of view, shouldn't the matching parenthesis have the same font color as the other parenthesis?

keysym commented 5 years ago

So, I tested kuroi.vim in some terminal emulators: qterminal, lxterminal, sakura, termite, konsole and mate-terminal.
I only got the correct result with sakura and termite.

I tried to make it work on lxterminal but everything failed. Since I was already thinking about migrating to termite, this is my chance! I think this problem happens because of a different way of dealing with the cursor.

I wonder if more people have experienced this problem, but, if people show no interest in this topic, we can consider this pull request as closed!

aonemd commented 5 years ago

Also tested and works in both st and kitty terminals.

I think this might have to do with the color of the cursor in your terminal config.

keysym commented 5 years ago

Well, it all points to a local problem.

Since I've changed my terminal emulator and everything looks fine... Thanks for your attention! ;D