search

aonez / Keka

The macOS & iOS file archiver
https://www.keka.io
4.58k stars 232 forks source link

[BUG] Stuck if 50+ files are uncompressed #1438

Open 2V3EvG4LMJFdRe opened 2 months ago

2V3EvG4LMJFdRe commented 2 months ago

Configuration

Describe the bug

Both on an HDD and an SSD, Keka becomes unresponsive upon opening files in the range of over 50. Keka does nothing and requires Force Quit.

To Reproduce

Steps to reproduce the behavior:

  1. Select 100+ .zip or .rar files in Finder
  2. Press Command + Down

Expected behavior

The files are queued and extracted one by one.

aonez commented 2 months ago

50 or 1000 files?

On Wed, Apr 24, 2024 at 21:12 2V3EvG4LMJFdRe @.***> wrote:

Assigned #1438 https://github.com/aonez/Keka/issues/1438 to @aonez https://github.com/aonez.

— Reply to this email directly, view it on GitHub https://github.com/aonez/Keka/issues/1438#event-12596898043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADVHIYKDUC2KLP4O7XEWO3Y6772XAVCNFSM6AAAAABGXQAVA6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGU4TMOBZHAYDIMY . You are receiving this because you were assigned.Message ID: @.***>

gingerbeardman commented 2 months ago

Out of interest, does Finder warn you before opening this many files?

2V3EvG4LMJFdRe commented 2 months ago

50 or 1000 files?

It's something over 50, but it's definitely not set in stone since I tried around 60 files when I wrote the issue and they uncompressed fine. Over 100 it crashes for sure, at least with these files (cbr comic books, so jpg/png images).

For reference, The Unarchiver works at a significantly larger number - can get at least 300 of these files queued, but I know 1000+ makes it so slow it stops being useful (although not unresponsive like Keka).

Out of interest, does Finder warn you before opening this many files?

Nope.

gingerbeardman commented 2 months ago

Out of interest, does Finder warn you before opening this many files? Nope.

Interesting, because Finder should warn at anything above 25 files.

image

edit: Ah, only since macOS Mojave 10.4 https://apple.stackexchange.com/questions/342994/is-there-a-way-to-turn-off-the-are-you-sure-you-want-to-open-25-items-warning

aonez commented 2 months ago

Dropping the files to the window or the icon in the dock, or even invoking the extension action probably does not show the warning.

On Thu, Apr 25, 2024 at 15:17 Matt Sephton @.***> wrote:

Out of interest, does Finder warn you before opening this many files? Nope.

Interesting, because Finder should warn at anything above 25 files.

Upload.from.GitHub.for.iOS.png (view on web) https://github.com/aonez/Keka/assets/49612/873fe31c-aa73-48b0-9086-7a4f0ffad26c

What macOS? Any other system info?

— Reply to this email directly, view it on GitHub https://github.com/aonez/Keka/issues/1438#issuecomment-2077159145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADVHIZDH5A6NJB73C5NFKDY7D655AVCNFSM6AAAAABGXQAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZXGE2TSMJUGU . You are receiving this because you were mentioned.Message ID: @.***>

gingerbeardman commented 2 months ago

Right, but the OP says the do Cmd+down in Finder to open the files

2V3EvG4LMJFdRe commented 2 months ago

I just wanted to be specific about the way I feed them to Keka. It crashes likewise if I use the service "Extract using Keka".

I'm up for testing a random assortment of compressed files if anyone wants to upload that. We could confirm that a group of files uncompress ok on their end, but make Keka freeze on mine.