ZIP extraction containing backwards slashes \ in path names

strauhmanis commented 3 weeks ago

Hello Jorge,

Configuration

Keka version: 1.4.3 (5464) MAS
macOS version: 14.6.1

Describe the bug

Keka incorrectly extracts paths / folders.

To Reproduce

Steps to reproduce the behavior:

Go to https://github.com/Tranquiliti/CustomizableStarSystems/releases
Download CustomizableStarSystems-v2.1.0.zip
Extract the file with Keka
See error

Expected behavior

Keka should extract the paths / folders in the same way as does macOS built-in Archive Utility.

Screenshots

See the attached screenshots of the archive extracted both with Keka and the Archive Utility.

Thank you Keka macOS14

gingerbeardman commented 3 weeks ago

Interesting!

% file CustomizableStarSystems-v2.1.0.zip 
CustomizableStarSystems-v2.1.0.zip: Zip archive data, at least v2.0 to extract, compression method=store

These fail for me:

Keka
Better Zip

This fails in a different way

The Unarchiver
unzip (cli)
7z (cli)

These work:

Archive Utility (macOS Sonoma)
MacZip

aonez commented 2 weeks ago

This is fixed in the 2.1.1 release of CustomizableStarSystems. The issue is in the ZIP itself that is using backwards slashes \ instead of forward slashes / in the path names. As stated in the APPNOTE.txt:

   4.4.17 file name: (Variable)

       4.4.17.1 The name of the file, with optional relative path.
       The path stored MUST NOT contain a drive or
       device letter, or a leading slash.  All slashes
       MUST be forward slashes '/' as opposed to
       backwards slashes '\' for compatibility with Amiga
       and UNIX file systems etc.  If input came from standard
       input, there is no file name field.

The bundled archiver and MacZip are converting those slashes. This can have unexpected results, even if in this case "fixed" the bad crafted ZIP file.

aonez / Keka