aonez / Keka

The macOS & iOS file archiver
https://www.keka.io
4.71k stars 236 forks source link

Icon issue on macOS 10.15 Catalina #453

Open DesertRec opened 4 years ago

DesertRec commented 4 years ago

👉 This seems will never be fixed in Catalina. Big Sur has this fixed anyway.

Original report:

I recently bought Keka from app store when I was using Mojave, I then made a clean install with Catalina and now the zip icon doesn't look right.

image
aonez commented 4 years ago

Thanks for the tip @coz2001, recently today saw that same icon in a friend's MacBook running Catalina.

Deathlike commented 4 years ago

This could also be an issue with mac OS Catalina. Other apps are also doing this with ZIP files and if you try reverting the file association to the default Archive Utility app, instead of the OS ZIP icon you'll get the same white page with the Archive Utility icon in the middle.

This isn't exclusive to ZIP icons either. I've seen it with GZ archive aswell.

keka_as_default Screen Shot 2019-10-10 at 14 07 25 Screen Shot 2019-10-10 at 14 12 57
aonez commented 4 years ago

Indeed. I’ve contacted with the Apple Developer support and they asked me to submit a bug report. So hopefully this will be fixed in macOS 10.15.1.

I’ll be linking the information to this issue. I suggest you also report this bug using the Feedback Assistant.

aonez commented 4 years ago

Checked latest Catalina version with yesterday's supplemental update (19A602), same issue.

aonez commented 4 years ago

Same on 10.15.1 Beta 2 (19B77a).

aonez commented 4 years ago

Does not seem to be fixed on 10.15.1 Beta 3 (19B86a)

DesertRec commented 4 years ago

Thanks for the update, I really hope it eventually will be fixed the icons just look wrong.

abdelle7 commented 4 years ago

Same here on macOS 10.15 (19A603).

aonez commented 4 years ago

Please, to all that are facing this issue, report it to Apple via the Feedback Assistant app that is bundled in macOS. I've already reported it (FB7365951) on October's 10th, with no reply yet.

DesertRec commented 4 years ago

I just reported the issue.

naturalkei commented 4 years ago

This is a catalina compatibility issue in the keka app because other applications will see the icon of that type as normal.

jianglai commented 4 years ago

This is a catalina compatibility issue in the keka app because other applications will see the icon of that type as normal.

I think this is a general Catalina bug. As mentioned above the built-in archive utility app also has the same problem.

alvarnell commented 4 years ago

Is it really a problem, or just a change?

Sent from my iPad

-Al-

aonez commented 4 years ago

macOS 10.15.1 (19B88) still has the issue as expected, since it was not fixed in the betas.

@alvarnell I see this as a bug, since the specified icons are not displayed and even the file type descriptions are wrong #472.

@Euiyeon I did lots of tests, with multiple icons and empty app projects, always with the same results. Then @Deathlike shared the screenshot of the same issue in Archive Utility. Also contacted with Apple Developer support and they told me to fill the bug report.

Again, all users facing this issue should report it to Apple using the Feedback Assistant app.

aonez commented 4 years ago

Still happening in latest 10.15.2 beta 1 (19C32e). And sadly still no reply on the Feedback Assistant issue.

Screen Shot 2019-11-07 at 21 36 42

aonez commented 4 years ago

Still the same in 10.15.2 beta 2 (19C39d).

Screen Shot 2019-11-14 at 09 11 05

timothy-morph commented 4 years ago

Weird......and my PDF files also have similar problems with Acrobat...

aonez commented 4 years ago

Please report it to Apple.

On Mon, 18 Nov 2019 at 17:29, timothy-morph notifications@github.com wrote:

Weird......and my PDF files also have similar problems with Acrobat...

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/aonez/Keka/issues/453?email_source=notifications&email_token=AADVHIYPYP3ENHCLMKG3CM3QUK7GVA5CNFSM4I67PK3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELBJQY#issuecomment-555095235, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADVHI5AWQLUVRU3Q65YSYDQUK7GVANCNFSM4I67PK3A .

jankytay commented 4 years ago

I think it's the extra "IconVariant" property that's throwing Finder off. After these steps, I can get the Finder to display Keka icons normally:

  1. Remove existing Keka
  2. Download a new copy from the website
  3. Decompress the .app into desktop
  4. Reset quarantine tag and self-sign the executable (otherwise the system will refuse to run the modified app)
  5. Remove all the "IconVariantblah" in Info.plist
  6. Launch Keka & set as default decompressor
  7. Relaunch Finder

=== Environment: macOS 10.15.2 Beta (19C39d) Keka 1.2.0-dev (3575)

aonez commented 4 years ago

@jankytay there're multiple extra keys in there, not only IconVariant. I've tried removing it anyway with no different results, so maybe is the self sign the difference that helped you. You've signed it with a developer signature?

aonez commented 4 years ago

@jankytay could you share that self signed build?

jankytay commented 4 years ago

@aonez no, I signed with ad-hoc sudo codesign -f -s - Keka.app/Contents/MacOS/Keka and replaced all \t+<key>IconVariant</key>\n\t+<string>.+</string>\n in Info.plist

jankytay commented 4 years ago

i think trying to reproduce the whole process locally is more efficient than me uploading a 20M+ zip file 😅

aonez commented 4 years ago

@jankytay no change for me. Note that some formats not compatible with the built-in archiver (like TXZ and TLZ) have that IconVariant key and work properly.

aonez commented 4 years ago

Still no change in 10.15.2 beta 3 (19C46a).

Screen Shot 2019-11-21 at 11 02 57

aonez commented 4 years ago

@jankytay, this build only has ZIP in the Info.Plist, with no other than the default keys in it: Keka.tar.zip

Fails the same for me.

jankytay commented 4 years ago

huh, now this is one tricky bug to pinpoint the issue welp, i tried...

aonez commented 4 years ago

yep, thanks a lot for your feedback anyway ^^ Still this seems to be a bug in Catalina's lsd or similar that they're not yet taking care of.

jankytay commented 4 years ago

no problem, thank you for verifying it at least it works on my machine™

mupkoo commented 4 years ago

Not sure if this is documented somewhere, but this might help https://stackoverflow.com/questions/58220256/file-icons-getting-changed-to-app-icon-in-macos-catalina

aonez commented 4 years ago

Thanks for the tip @mupkoo! It's the same issue but the solution suggested by Thomas Zoechling was already applied in Keka long time ago and does not solve the Catalina issue.

qyaaang commented 4 years ago

I also have the same issue with Microsoft excel file icon and Adobe Acrobat file icon.

aonez commented 4 years ago

@yangqun1993 be sure to report it to Apple :)

abdelle7 commented 4 years ago

@aonez Any good news ??

aonez commented 4 years ago

@abdelle7 sadly in the latest 10.15.3 Beta 1 (19D49f) this is still present...

adamwinn commented 4 years ago

I'm seeing this with all sorts of other apps too

fACEd-star commented 4 years ago

Try COMPLETELY uninstalling VLC media player (if you have) restart and then install again. It works for me. It was a problem past association some archives (rar?) with VLC...

mamengcode commented 4 years ago

I also have the same issue with Microsoft excel file icon and Adobe Acrobat file icon.

Is this a bug of macOS Catalina? I just have it for pdf files, and my excel files are okay.

aonez commented 4 years ago

@flyseeksky it is indeed a bug of macOS Catalina, please see the instructions to report it to Apple.

bradleybowman commented 4 years ago

Also experiencing this issue, and have been since the Catalina upgrade.

I only began using macOS and Keka shortly before Catalina was released (picked up a 2012 Mac Mini for a good price, and grabbed Keka from the App Store). Wish I'd found this thread earlier; I thought it was just me. Reported the issue to Apple per your instructions.

Thanks for your work!

aonez commented 4 years ago

Thanks @bradleybowman! I've checked 10.15.4 beta 5 last week and still has this issue. No word on the issues reported to Apple, sadly. It seems this will not be fixed in Catalina, maybe in 10.16.

ghost commented 4 years ago

Very interesting. I got this issue now too.

-Got a new Mac with Catalina pre-installed -Upgraded to latest Catalina version -Downloaded Archiver app (before found about Keka) -Zip file icons have Archiver's icon on top of the generic white document icon -Downloaded IINA media player -MKV file type icons appeared normally with IINA's MKV specific icon -Downloaded Submerge which changed all media files to open with it without asking the user -Changed MKV and other media files to open with IINA again -Now the MKV file type icon is the IINA app icon on top of the generic white document icon

I can change the MKV file type icon manually per file using Get Info but obviously it doesn't get changed across every MKV, only the selected one.

Very frustrating.

Submitted feedback to Apple using Feedback Assistant. Recommend others to do the same.

How can such a simple thing be broken so long?

aonez commented 4 years ago

How can such a simple thing be broken so long

Catalina reminds me of Lion... I'm just skipping it altogether, it only lives in a virtual machine. Mojave is pretty stable.

JihongWEI commented 4 years ago

This may be a bug of Catalina. At present, my personal solution is to create a new account. The file ICONS with the suffix zip and docx can be displayed normally.

syo093c commented 4 years ago

I also have this problem. IINA and Keka are both work incorrectly. Catalina is a PURE GARBAGE!

i0ntempest commented 4 years ago

I got this solved using a little piece of software called RCDefaultApp. It's old and a bit buggy but does the job for me. You first install the preference panel, then goto Extensions tab, then for every file type that has the bad icon, choose <disable>. It may then show another app is selected, but if you do $ killall Finder the icon should be fixed.

T-Bone90 commented 4 years ago

I got this solved using a little piece of software called RCDefaultApp. It's old and a bit buggy but does the job for me. You first install the preference panel, then goto Extensions tab, then for every file type that has the bad icon, choose <disable>. It may then show another app is selected, but if you do $ killall Finder the icon should be fixed.

RCDefaultApp dosn't work with Catalina. Or how it works?

i0ntempest commented 4 years ago

I got this solved using a little piece of software called RCDefaultApp. It's old and a bit buggy but does the job for me. You first install the preference panel, then goto Extensions tab, then for every file type that has the bad icon, choose <disable>. It may then show another app is selected, but if you do $ killall Finder the icon should be fixed.

RCDefaultApp dosn't work with Catalina. Or how it works?

It is really outdated but works for me, at least for this purpose.

T-Bone90 commented 4 years ago

I got this solved using a little piece of software called RCDefaultApp. It's old and a bit buggy but does the job for me. You first install the preference panel, then goto Extensions tab, then for every file type that has the bad icon, choose <disable>. It may then show another app is selected, but if you do $ killall Finder the icon should be fixed.

RCDefaultApp dosn't work with Catalina. Or how it works?

It is really outdated but works for me, at least for this purpose.

How? I install it but Catalina won't open the App in the Settings. I only have the option move to the trash.

i0ntempest commented 4 years ago

I got this solved using a little piece of software called RCDefaultApp. It's old and a bit buggy but does the job for me. You first install the preference panel, then goto Extensions tab, then for every file type that has the bad icon, choose <disable>. It may then show another app is selected, but if you do $ killall Finder the icon should be fixed.

RCDefaultApp dosn't work with Catalina. Or how it works?

It is really outdated but works for me, at least for this purpose.

How? I install it but Catalina won't open the App in the Settings. I only have the option move to the trash.

Try manually copying it to /Library/PreferencePanes first, if doesn’t work try disabling gatekeeper: $ sudo spctl --master-disable, if still doesn’t work disable SIP