aonez / Keka

The macOS & iOS file archiver
https://www.keka.io
4.83k stars 238 forks source link

Dropping multiple files on Keka icon in the Dock produces two archives instead of one #77

Open giftal opened 7 years ago

giftal commented 7 years ago

Issue: instead of making 1 archive out of N (N >= 99) dropped files, Keka makes 2 archives: 1st on one of the dropped files, 2nd on - all the other N-1 files.

Steps to reproduce:

  1. Place a Keka icon to the Dock (Right click on the icon => "Options" => "Keep in Dock")
  2. Exit Keka (Right click on the icon => "Quit")
  3. Open Finder and select N >= 99 files. Drag and Drop selected files on Keka icon in the dock.
  4. See how Keka starts to create Compressed file.7z and one more archive. Expected: only Compressed file.7z created with all N files inside.
aonez commented 7 years ago

I can't reproduce your concrete >=99 case, but I think this must be the same as #57. If you can reproduce it with your >=99 files, please add them to a DMG, zip it and attach it here.

Also take a look at the example on #57, it contains a folder ("Drop whatS inside here") with 2 files and a folder that should give you the same problem you're facing. Let me know if it doesn't.

aonez commented 7 years ago

I'm working on a fix, thoug it is not yet stable: Keka-1.1.0-beta.3r2212.zip

This version is just for testing this issue, don't use it as your stable version.

giftal commented 7 years ago

Hello @aonez , I agree this is a duplicate for #57 . Please find my 99 files here: ~REMOVED~ Please kindly say when you download them, I will delete the archive from google drive. Thank you!

aonez commented 7 years ago

You can delete it. Just not tested yet.

aonez commented 7 years ago

I can't reproduce the error compressing your csv files. The reason I've asked you to add them first to a DMG is because then they store al metadata that I think causes the bug.

Can you reproduce the bug with the files inside the one you've sent me? Not the originals, but the ones inside Compressed file_all.7z, after they're extracted? If not, please repack the original files on a DMG and share it with me.

Also, there's some special application you use to open csv files?

Thanks a lot @giftal for your feedback, maybe we can get to a clear point of #57 and this one.

giftal commented 7 years ago

Can you reproduce the bug with the files inside the one you've sent me? Not the originals, but the ones inside Compressed fileall.7z, after they're extracted? I could not. So yes - you are right, this is likely to be about the metadata.

I have created a DMG image containing 2 files. Please download here: ~REMOVED~ (Please, again, kindly say when you download them, I will delete the archive from google drive. Thank you!) The file with filename starting with "Si-" always gets to be packed separately from all the other files. I have included only 1 additional file - feel free to add your files to my DMG image, feel free to study all about this "Si-" file. Will gladly try to help you further. Thank you for the Keka app.

aonez commented 7 years ago

You can delete the file 👍

aonez commented 7 years ago

What application do you use to open the .qshfile?

I can't reproduce the bug either, so I suppose it has something to do with the application that handles this file.

giftal commented 7 years ago

I use wine + freeware prog: (https://www.qscalp.ru/store/qsh2txt.zip)

aonez commented 6 years ago

Finally reproduced the issue and I'm working on that. Just trying to get the less performance impact solution for this.

aonez commented 6 years ago

I'm still unable to find an stable fix for that issue. In the upcoming version this is completely fixed in the context menu services and for weightless compressions. But I recommend using those workarounds for lots of big files operations:

aonez commented 6 years ago

@giftal just released beta 10 that has a fix for this issue, if you can't try it.