search

aooyoo / dabr

Automatically exported from code.google.com/p/dabr
0 stars 0 forks source link

Links break at quote marks #188

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What are the steps to trigger the problem?

Tweet a valid Google search URL including quote marks like 
https://encrypted.google.com/search?&q="Cath+Kitson"+age

See, for example:

http://dabr.co.uk/status/63998603693268993

What happened?

Rendered as:

<a href="https://encrypted.google.com/search?&amp;q=" 
target="_blank">https://encrypted.google.com/search?&amp;q=</a>"Cath+Kitson"+age

What did you expect to happen?

Render as a complete link:

<a href="https://encrypted.google.com/search?&amp;q=" 
target="_blank">https://encrypted.google.com/search?&amp;q="Cath+Kitson"+age</a>

(perhaps with character-encoding?)

Original issue reported on code.google.com by pigsotwing on 29 Apr 2011 at 4:17

GoogleCodeExporter commented 9 years ago 
Interestingly, this work when tweets are returned via the search API - see 
screenshot. 
I'll investigate and try and see what's causing it. We use the official 
Autolinker - so there shouldn't be any problems.

Original comment by terence.eden on 2 May 2011 at 1:41

Attachments:

GoogleCodeExporter commented 9 years ago 
This looks to be a bug in twitter...
See the XML for that status
http://api.twitter.com/1/statuses/show/63998603693268993.xml?include_entities=1
Or the JSON if you prefer
http://api.twitter.com/1/statuses/show/63998603693268993.json?include_entities=1

You'll see that twitter doesn't recognise the " as part of the URL, nor do they 
escape it in the JSON. It also doesn't include it in the entities.

Investigation continues.

Original comment by terence.eden on 5 May 2011 at 10:45

GoogleCodeExporter commented 9 years ago 
Indeed, even the main twitter site doesn't recognise it as a URL
http://twitter.com/#!/pigsonthewing/statuses/63998603693268993

Tempted to say PEBCAK - you should be using percent encoding like 
https://encrypted.google.com/search?&q=%22cath+Kitson%22+age - but I'll raise 
it with twitter.

http://code.google.com/p/twitter-api/issues/detail?id=2167

Original comment by terence.eden on 5 May 2011 at 10:57

GoogleCodeExporter commented 9 years ago 
Twitter will not fix this 
http://code.google.com/p/twitter-api/issues/detail?id=2167#c1

Original comment by terence.eden on 13 Jun 2011 at 12:26