search

aormsby / Fork-Sync-With-Upstream-action

An action to automatically update your fork with new commits from the upstream repo
MIT License
258 stars 70 forks source link

Default template comment is duplicated #28

Closed HarelM closed 3 years ago

HarelM commented 3 years ago

When copying the default template the pull and push comment is duplicated and therefore has a copy-paste typo... See here: https://github.com/aormsby/Fork-Sync-With-Upstream-action/blob/ac3bad798688ddf124b7d83a8e4fced59a1a83a7/action.yaml#L47 https://github.com/aormsby/Fork-Sync-With-Upstream-action/blob/ac3bad798688ddf124b7d83a8e4fced59a1a83a7/action.yaml#L42 Also the readme is talking about fetch_args, are these the same as pull_args? image

Thanks for this great Github Action!

aormsby commented 3 years ago

Ah I see, thanks for letting me know about the typo. About the fetch_args these are actually used when getting the latest updates from the upstream repo (before the merge). Then the pull_args are used when merging the data from upstream to the local repo. I realize it's not very clear, though, and it's possible the fetch_args may not even be all that useful. I'm working on a 3.0 update to the action, and I will be sure to try making that more obvious. Thanks for the feedback. :)

aormsby commented 3 years ago

Fixed in 2.4 and 3.0