Fix output was not set if fetching from upstream resulted in error

aormsby / Fork-Sync-With-Upstream-action

An action to automatically update your fork with new commits from the upstream repo

MIT License

258 stars 70 forks source link

Fix output was not set if fetching from upstream resulted in error #48

Closed ghost closed 2 years ago

aormsby commented 2 years ago

Was this causing an issue? I remember all my tests going fine when I didn't explicitly the output to false. Probably a good fix, just want to understand your use case.

ghost commented 2 years ago

If the output value is empty, then both checks output == 'true' and output == 'false' return false in subsequent steps or jobs

Without the fix

With the fix

https://github.com/Fubuchi/clr-boot-manager/blob/846892eee9/.github/workflows/main.yml#L58

aormsby commented 2 years ago

Sweet, thanks for sharing. I'll merge this. 👍

I'm waiting on another issue fix to be confirmed right now. I think I'll put them together in the same release. Shouldn't be too long.

aormsby commented 2 years ago

Pre-released to v3.3!