search

aosapps / drone-sonar-plugin

The plugin of Drone CI to integrate with SonarQube (previously called Sonar), which is an open source code quality management platform.
MIT License
30 stars 51 forks source link

Update versions #35

Open tkushnir opened 2 years ago

tkushnir commented 2 years ago

@roganw: Please, comment on this.

Elanis commented 2 years ago

Hi !

Sorry to highjack a bit your PR.

As stated in #36, we're using an EOL nodejs version for this runner. As you're updating some dependancies/runtimes on this image, could you check nodejs version in your new image, and if possible install latest LTS (v16) as stated on official guide (https://github.com/nodesource/distributions/blob/master/README.md#installation-instructions) ?

Thanks !

tkushnir commented 2 years ago

Hi @Elanis!

I used openjdk:11.0.14.1-jre image for the plugin, which is based on Debian 11 (bullseye). The nodejs package is installed then from that distribution and has version 12.22.5. If we need to run latest LTS of nodejs we should use some other base image or more recent distribution.

I have no plans upgrading Debian 11 in openjdk base image, so the nodejs package version will be 12.22.5 for now.

UPD:

We can switch to sonarsource/sonar-scanner-cli:4.6 base image, where Alpine 3.14 is used as a base. There is nodejs version 14.19.0 there. Maybe this will be the best option.

Elanis commented 2 years ago

Okay, thanks for checking :) NodeJS 12 has a EOL a year later than v10 (2022-04-30 instead of 2021-04-30). That's better than the previous one :) But that's still short yeah, would be better for us to go on 14. or 16. using another image or NodeJS official repositories. If needed, I will do another PR after yours to upgrade node.

tkushnir commented 2 years ago

@Elanis I updated the PR to use sonarsource/sonar-scanner-cli:4.6 base image.

KADacey4 commented 2 years ago

@roganw Can this be reviewed and merged?

achepukov commented 11 months ago

@roganw Can this be reviewed and merged?