search

aotaduy / eslint-plugin-spellcheck

MIT License
183 stars 17 forks source link

omit module name in require statements #51

Closed tkharuk closed 4 years ago

tkharuk commented 5 years ago

fixes #45 checks for require function.

sholsinger commented 5 years ago

I submitted a PR to your fork @TuxujPes to add a configuration option for this functionality. Would you please accept and squash it into this PR?

sholsinger commented 5 years ago

@aotaduy It seems you disagree with including this functionality and would instead request that users apply an ignore word rule. (Based on the conversation in issue #45)

Given how simple and unobtrusive this PR is, does it really hurt the application to add it? Especially given the fact that there is already special handling for import declarations. I see this PR as we're merely allowing for the defacto standard import declaration to be supported and per your request, I've added a configuration option to make it optional.

aotaduy commented 4 years ago

Hi guys I was some time away from this project. Im mostly working on typescript now. Will try to keep up maintaining it. Thanks for the changes I think you are right about the feature not harming in any way the code. Thanks for The PR.