search

aotaduy / eslint-plugin-spellcheck

MIT License
183 stars 17 forks source link

Refactors performance test to work with gulp 4.x #53

Closed sholsinger closed 4 years ago

sholsinger commented 5 years ago

Refactors & fixes broken performance test.

Also in this PR:

I Reduced the timeout setting to 500ms; I think this test is fundamentally flawed, and we should instead be somehow recording the time it takes to run the unit tests and figure out a reasonable limit for what that should be. (and increase as those use cases grow -- as needed) For example, it looks like the unit tests run in ~850ms now. So we could set the limit for them to 900ms.

aotaduy commented 5 years ago

Yoe are right on the test being flawed i had started with the idea of improving performance and never had the time to finish. I will be removing this test.

aotaduy commented 4 years ago

I think the "performance test" is really flawed as you said so im removing them at all. I will come back with some better option to test and improve perfomance. Thanks!