Incoherent code in "void __not_in_flash_func(core1_main())", in "inty_cart.c" module.

aotta / PiRTOII

New PiRTO multicart for Intellivision, now based on Pico clone

21 stars 0 forks source link

Incoherent code in "void __not_in_flash_func(core1_main())", in "inty_cart.c" module. #5

Closed dombru54 closed 3 months ago

dombru54 commented 3 months ago

Hello, There is an unconditional "break" in this "for", "break" should be in "if". if (hacks>0) { for (int i=0; i<maxHacks;i++) { if (parallelBus==HACK[i]) { dataOut=HACK_CODE[i]; deviceAddress = true; } break; } }

aotta commented 3 months ago

Hi, you're right, break position fixed in source

dombru54 commented 3 months ago

Your welcome ! Congratulations, aotta, for your shared project. I am putting it into service