search

aourednik / historical-basemaps

Collection of georeferenced boundaries of world countries and cultural regions for use in mapping historical data on global or continental scale
GNU General Public License v3.0
441 stars 75 forks source link

Strange color for Italy #22

Closed giosonego closed 2 years ago

giosonego commented 2 years ago

I notice that in 1920 (and at least even in 1960) Italy is represented with a light-grey color that make impossibile to distinguish it form contiguous Yugostlavia. The color let think that there are some data missing. Fotografia_dello_schermo_062222_042641_PM

aourednik commented 2 years ago

This repository contains only raw polygon geometries and svg renderings; the colors are not registered in the data. The SVG rendrings (with random colors) do not show the same problem for this region.

image

The identical colors are determined by the coloring algoritm in the country borders app. That app's maintainer is @nrgapple. It is better you report this problem here: https://github.com/nrgapple/historic-country-borders-app/issues

nrgapple commented 2 years ago

@giosonego track the issue here

easy fix. don't know if it will make things better or worse but basically every country name is converted into a color. I just need to tweek that function

giosonego commented 2 years ago

Now it is much better. Thank you. image