search

ap / vim-buftabline

Forget Vim tabs – now you can have buffer tabs
http://www.vim.org/scripts/script.php?script_id=5057
MIT License
782 stars 75 forks source link

Add graphical separator between buffer names #4

Closed saro closed 9 years ago

saro commented 9 years ago

With this simple change I added a separator between the buffer tabs. This should make easier read the list of buffers. Sorry if the change is really simple (and may be not totally correct), but it's my first experience on vimscript. Thanks, Saro

ap commented 9 years ago

I tried to add a separator but couldn’t find an approach I was satisfied with. You can’t just replace the padding with a pipe, then the tabs look unbalanced. If it’s drawn between tabs then it takes up even more room, and to my mind it also needs a separate highlight group. Unfortunately Vim only supplies 3 of those and I already need 4 without separators (so I stole one from the popup menu, hoping that this will usually harmonise with the tabline automatically).

But I figure, it’s not gonna be perfect, but I could just cheat.

As for the patch itself, I can’t take it since the rendering needs to be changed in 5 other places, and it’s missing docs. But I can do all that myself, no prob.

Can you pull the sep branch and tell me whether that looks fine for you?

saro commented 9 years ago

Just tried the sep branch and it works good to me. As you said it could be better have the separator with a different highlight but it's still fine. Do you think to merge this to master adding eventually an option to enable it? Thanks, Saro

ap commented 9 years ago

That’s the plan.

ap commented 9 years ago

Done.