search

ap / vim-css-color

Preview colours in source code while editing
http://www.vim.org/scripts/script.php?script_id=5056
MIT License
1.77k stars 78 forks source link

Add support for dosini configuration #100

Closed ix5 closed 6 years ago

ix5 commented 6 years ago

Don't merge this yet, dosiniValue support depends on the PRs I've opened with https://github.com/vim/vim/pull/3422 and https://github.com/neovim/neovim/pull/8978

Thank you @ap for this plugin!

ap commented 6 years ago

Thanks. Normally I’d merge anyway, since adding support for highlight groups that don’t exist everywhere doesn’t do any harm – that’s how a bunch of the supported syntaxes support multiple 3rd party syntax plugins. But in this particular case it’s also unclear whether the highlight group ships at all, whether it ships under that particular name, and whether it ships the same in both Vim and Neovim… so yeah, I’ll wait and see how the other tickets develop.

ap commented 6 years ago

Now that @xuhdev has shipped your patch, I’ve pushed this as 3a49517de8d93b1443197de9820a3024f014e3a4. Thank you for the patch.