Open mbertheau opened 10 years ago
Personally I wouldn’t use it.
I’m also not even inclined to try doing it because I expect it won’t work well. Consider that there would be many fewer pixels with the CSS colour, so the colour won’t stand out as well. And what to do with the background colour – leave it alone? Then depending on the user’s theme that would make some foreground colours invisible or hard to read. Make it black or white depending on the foreground colour? But black would look like a hole in the screen and white would overwhelm the dark text colour it would be contrasting against.
But if it’s simple enough to implement, so that maintaining it in the future won’t annoy me, I’ll accept a patch that provides this as an option.
@ap What if there's a background and a foreground color in the same declaration block?
Then what do you want to do? Colourise… what, the inside of the entire block? That will produce an ugly colour highlight block with jagged edges at the top and bottom; and what if there are multiple declarations? Or, just colourise the color
directive after the background
directive, and vice versa? Seems a little limited/anticlimactic visually… And ever the issue of the readability of your source depending on the content of your source.
Stepping back, I guess the real requested feature here is to be able to have a sort of colour proof right in the source.
I think it would be more appropriate to achieve that by supporting something like a special comment form that gets highlighted in the applicable colours, so you can then add such a comment during editing, any time you want it, with any (amount of) example text inside. Or, maybe a toggle key map
that just temporarily highlights the current line with the applicable colours. Something like that is how I think I would approach the feature, if I ever add it.
@ap You're of course right, this feature request is about the colour proof right in the source.
I actually like the idea of colourizing just the color
and background-color
directives.
What do you think about showing the CSS color not as the background color but as the text color if it's a
color:
rule?