ap / vim-css-color

Preview colours in source code while editing
http://www.vim.org/scripts/script.php?script_id=5056
MIT License
1.79k stars 80 forks source link

Feature Request: highlight color from visual selection #99

Open amerov opened 6 years ago

amerov commented 6 years ago

Sometimes I want to see color from js or other filetypes. Use case example: select color from string {color: '#fa755a'} and run command :Showcolor

joeytwiddle commented 6 years ago

Please check if this applies: https://github.com/ap/vim-css-color/issues/85#issuecomment-278518237

If your situation might also be a situation that other developers have, we should try to add automatic support first, before looking into manual support.

That said, I can see some use for manual coloring. Strings like'#feed', '#fade', '#101' could be RGBA/RGB colours, or they could hashtags or URL anchors.

ap commented 6 years ago

Well, it depends.

If the idea is to have a feature to say “highlight me this bit of an otherwise non-highlighted buffer”, then yes, that’s not something I feel like writing, nor something I’d want to maintain inside this plugin.

But it would certainly make sense to have a “show me a message in this colour in the command line” command that’s completely independent of what’s going on inside any buffer, just on general principle.

And along those lines it also seems reasonable to expose the RGB conversion code from the plugin so that other people can use it to write features I’m not willing to have in the plugin itself.