search

ap4y / OrigamiEngine

Lightweight audio engine for iOS and OSX with flac, cue, mp3, m4a, m3u support.
http://ap4y.github.com/OrigamiEngine/
MIT License
545 stars 118 forks source link

Adds HTTPHeaders for playing from http source #49

Open igorkravchenko opened 9 years ago

igorkravchenko commented 9 years ago

Sometimes it is required to send HTTP headers along with URL. Is there a chance we can add this?

mmcdole commented 9 years ago

:+1: this would be amazing.

sadhiappan commented 9 years ago

I often have to play mp3s from sources that require oauth authorization headers.  This would help me out a lot. The changes made my @igorkravchenko looks pretty clean. Would love to have it in master.

ap4y commented 9 years ago

For some reason I missed this PR, I think I was on vacation around that time :) Will merge in next couple days.

igorkravchenko commented 9 years ago

Still on vacation? ;)

ap4y commented 9 years ago

Sorry for not responding previously. I didn't merge this PR because I didn't like idea of having plugin specific options on engine mediator (plus some code styling issues). I tried to draft different implementation, but got sidetracked as always. Right now I'm not too interested in investing much time into new features, as described here. If someone needs this feature, I think it should be ok to use your branch or fork and patch.