search

ap4y / OrigamiEngine

Lightweight audio engine for iOS and OSX with flac, cue, mp3, m4a, m3u support.
http://ap4y.github.com/OrigamiEngine/
MIT License
545 stars 117 forks source link

Fixes for issues #6, #7 and #8 #9

Closed lawicko closed 11 years ago

lawicko commented 11 years ago

Hi, these are the fixes for the above mentioned issues, I'm not sure why I couldn't use the code as the static library, but adding those imports allows me to use it without cocoa pods. There is one more issue that I see which is that the playback will stop if the delegate method returns invalid url, but I'll fix that later. Great lib by the way, the only one I found which allows for a sample precision continuous playback (except AVFoundation but this one freezes when manipulating playback queue, see here: http://stackoverflow.com/questions/16654300/avqueueplayer-playback-freezes-when-removing-items-from-queue)

Cheers! Jakub

ap4y commented 11 years ago

Hey Jakub,

Thanks for the issue reports and pull requests! I'm really appreciate that. I will into you code tonight.

ap4y commented 11 years ago

Hey Jakub,

Thanks again for the PR, I have merged it and applied minor changes:

  1. I replaced CGFloat with simple float volume control accessors, since underlaying class is basically a float for all architectures. This was my mistake from the beginning.
  2. I reformatted code a bit from to return early rather than nesting inside if clause.

Hope you don't mind this changes.

Cheers!