apa512 / clj-rethinkdb

Eclipse Public License 1.0
205 stars 42 forks source link

Use protocol buffers to get the response and error type values #165

Closed danielcompton closed 8 years ago

danielcompton commented 8 years ago

Using the protocol buffer definitions for response and error types makes the code more self documenting, and less prone to error when transcribing response or error types.

danielcompton commented 8 years ago

There's a problem with using Java enum's in case statements. There is a solution at http://stackoverflow.com/questions/16777814/is-it-possible-to-use-clojures-case-form-with-a-java-enum, but it's pretty ugly, and probably not worth the extra complexity.